Skip to content

Fix empty list rendering on Firefox and the bug of editing lists with empty items#726

Closed
nushea wants to merge 3 commits intoSableClient:devfrom
nushea:fix-empty-list-rendering-editing
Closed

Fix empty list rendering on Firefox and the bug of editing lists with empty items#726
nushea wants to merge 3 commits intoSableClient:devfrom
nushea:fix-empty-list-rendering-editing

Conversation

@nushea
Copy link
Copy Markdown
Contributor

@nushea nushea commented Apr 30, 2026

Description

Fixes #711

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

The Gods have bestowed me with the wisdom of how to fix this

@7w1
Copy link
Copy Markdown
Member

7w1 commented Apr 30, 2026

Fix included in #727

@7w1 7w1 closed this Apr 30, 2026
@nushea
Copy link
Copy Markdown
Contributor Author

nushea commented Apr 30, 2026

That's nice, ngl i am excited for latex and this is a perfect combo whenever it gets merged

@nushea nushea deleted the fix-empty-list-rendering-editing branch April 30, 2026 07:06
7w1 added a commit that referenced this pull request May 4, 2026
…lugins for matrix things (#727)

<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Replaced Cinny's custom markdown parsing with marked which should
drastically reduce the various random obscure errors and crashes caused
by it.
Added math rendering support with KaTeX, sent using standard formatting
of $ for inline and $$ for block with LaTeX.

Supersedes #726
Fixes #711 
Fixes #587
Fixes #467  
Fixes #684 

Tbh I doubt I've tested this enough so there's probably still a bunch of
bugs, especially in parsing html back to markdown, but hopefully it's
less than our current system?

Might consider using another library like Turndown for converting html
into markdown, currently using a partial custom parser with... well okay
results.

Updated to also remove the WYSIWYG editor because it's largely unused,
can be entirely covered by markdown, and complicates translating html to
markdown. Keyboard shortcuts from the editor have been rewritten to
instead apply markdown syntax.

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [x] Breaking change - removes the WYSIWYG editor.
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->

Tests were AI generated and then reviewed by me. I can confirm that the
tests probably test the right stuff.
I had AI do the initial merge and write the marked plugins for the link
preview hiding and spoiler hiding features, which I then tested and
reviewed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editing a message containing a list with an empy last value will crash the client

2 participants