Fix empty list rendering on Firefox and the bug of editing lists with empty items#726
Closed
nushea wants to merge 3 commits intoSableClient:devfrom
Closed
Fix empty list rendering on Firefox and the bug of editing lists with empty items#726nushea wants to merge 3 commits intoSableClient:devfrom
nushea wants to merge 3 commits intoSableClient:devfrom
Conversation
Merged
11 tasks
Member
|
Fix included in #727 |
Contributor
Author
|
That's nice, ngl i am excited for latex and this is a perfect combo whenever it gets merged |
7w1
added a commit
that referenced
this pull request
May 4, 2026
…lugins for matrix things (#727) <!-- Please read https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before submitting your pull request --> ### Description <!-- Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Replaced Cinny's custom markdown parsing with marked which should drastically reduce the various random obscure errors and crashes caused by it. Added math rendering support with KaTeX, sent using standard formatting of $ for inline and $$ for block with LaTeX. Supersedes #726 Fixes #711 Fixes #587 Fixes #467 Fixes #684 Tbh I doubt I've tested this enough so there's probably still a bunch of bugs, especially in parsing html back to markdown, but hopefully it's less than our current system? Might consider using another library like Turndown for converting html into markdown, currently using a partial custom parser with... well okay results. Updated to also remove the WYSIWYG editor because it's largely unused, can be entirely covered by markdown, and complicates translating html to markdown. Keyboard shortcuts from the editor have been rewritten to instead apply markdown syntax. #### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [x] Breaking change - removes the WYSIWYG editor. - [ ] This change requires a documentation update ### Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings ### AI disclosure: - [x] Partially AI assisted (clarify which code was AI assisted and briefly explain what it does). - [ ] Fully AI generated (explain what all the generated code does in moderate detail). <!-- Write any explanation required here, but do not generate the explanation using AI!! You must prove you understand what the code in this PR does. --> Tests were AI generated and then reviewed by me. I can confirm that the tests probably test the right stuff. I had AI do the initial merge and write the marked plugins for the link preview hiding and spoiler hiding features, which I then tested and reviewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #711
Type of change
Checklist:
AI disclosure:
The Gods have bestowed me with the wisdom of how to fix this